Carlos Garnacho [Thu, 12 Oct 2017 12:18:12 +0000 (14:18 +0200)]
gtkwidget: Lookup target widget when propagating emulated pressed
After a gesture first claims, and later rejects a touch sequence,
a press event will be propagated further along. However propagation
got messed up since we only emitted as far as the toplevel.
Matthias Clasen [Thu, 12 Oct 2017 09:23:35 +0000 (17:23 +0800)]
Update the css style test
The new font-variant support affected the output here.
Matthias Clasen [Thu, 12 Oct 2017 08:05:32 +0000 (16:05 +0800)]
Make css node and style tests run
Just like the previous commit, we need to set G_TEST_SRCDIR.
Matthias Clasen [Thu, 12 Oct 2017 07:58:05 +0000 (15:58 +0800)]
Make css parser tests run
We need to set G_TEST_SRCDIR and friends for this to do anything.
Setting it reveals that a bunch of the tests are broken.
Matthias Clasen [Thu, 12 Oct 2017 01:09:21 +0000 (20:09 -0500)]
Update some a11y tests
Matthias Clasen [Thu, 12 Oct 2017 00:59:07 +0000 (19:59 -0500)]
Fix a typo
Matthias Clasen [Thu, 12 Oct 2017 00:33:43 +0000 (19:33 -0500)]
testsuite: cosmetics
Put all tests in a suite, and order them in a nicer way.
This makes the test output look better.
Daniel Boles [Wed, 11 Oct 2017 21:35:31 +0000 (22:35 +0100)]
Settings: Mention Shift+primary click on Range too
This already existed, and since this doc blurb is already inflating
dramatically, what’s another half a line?
Daniel Boles [Wed, 11 Oct 2017 20:23:20 +0000 (21:23 +0100)]
Settings: Reflect resurrected middleclick in Range
and while here, make the explanation more explicit as to which values do
what, & use general Range terminology instead of focussing on scrollbars
https://bugzilla.gnome.org/show_bug.cgi?id=787669
Daniel Boles [Wed, 11 Oct 2017 20:12:33 +0000 (21:12 +0100)]
ToggleButton: Actually show buttons in new snippet
Also, create a Window, instead of a Dialog without a transient parent,
which is (noisily) discouraged. Then s/content_area/box/g to match.
Emmanuele Bassi [Tue, 10 Oct 2017 09:19:53 +0000 (10:19 +0100)]
docs: Clarify the visibility of buttons in GtkStackSwitcher
If a page in the GtkStack is not visible, then the GtkStackSwitcher
won't show a button for it.
Matthias Clasen [Wed, 11 Oct 2017 19:07:53 +0000 (14:07 -0500)]
range: Bring back middle clicks
It does not hurt us to keep middle clicks doing the same
as shift-primary clicks. This makes the transition from gtk2
less painful in terms of muscle memory.
https://bugzilla.gnome.org/show_bug.cgi?id=787669
Philip Withnall [Tue, 10 Oct 2017 17:29:36 +0000 (18:29 +0100)]
gtktextview: Add a missing g_assert_not_reached() for switch default
Clarifies the code and helps catch invalid enum values before they
propagate further. Also add a comment about why two seemingly legitimate
values are not handled there (they’re handled higher up in the file).
Coverity CID:
1457700
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=788787
Timm Bäder [Wed, 11 Oct 2017 11:01:27 +0000 (13:01 +0200)]
bindings: Fix code snippet
Just use a more realistic example, adapted from gtklistbox.c
Timm Bäder [Wed, 11 Oct 2017 10:56:42 +0000 (12:56 +0200)]
accellabel: Fix code snippet
Timm Bäder [Wed, 11 Oct 2017 10:55:01 +0000 (12:55 +0200)]
aboutdialog: Fix code snippets
Define all variables and fix a missing comma in the first
gtk_show_about_dialog call.
Timm Bäder [Wed, 11 Oct 2017 10:41:47 +0000 (12:41 +0200)]
applicationwindow: Fix code sample
Declare all variables, use proper GtkApplication constructor and the
right GTK_APPLICATION() cast for gtk_application* API.
Timm Bäder [Wed, 11 Oct 2017 10:35:55 +0000 (12:35 +0200)]
togglebutton: Fix code snippet
Remove gtk_box_pack_start usage, gtk_dialog_get_content_area, fix wrong
gtk_dialog_new parameters and actually add a output_state callback.
Timm Bäder [Wed, 11 Oct 2017 10:21:20 +0000 (12:21 +0200)]
gtksettings: Fix code snippet
gtk_init does not take any arguments anymore and
GTK_TYPE_IMAGE_MENU_ITEM is gone.
Timm Bäder [Wed, 11 Oct 2017 10:18:22 +0000 (12:18 +0200)]
label: Make all code snippets properly compile
Timm Bäder [Wed, 11 Oct 2017 09:08:46 +0000 (11:08 +0200)]
accellabel: Document new API
Timm Bäder [Wed, 11 Oct 2017 08:55:20 +0000 (10:55 +0200)]
conview: Fix rubberband coordinates when scrolling
Timm Bäder [Wed, 11 Oct 2017 08:50:03 +0000 (10:50 +0200)]
iconview: Remove double-MAX when updating rubberband
Timm Bäder [Wed, 11 Oct 2017 07:24:35 +0000 (09:24 +0200)]
rendericon: Fix texture transformation
Use the one from snapshot_icon, which works.
Timm Bäder [Wed, 11 Oct 2017 07:03:40 +0000 (09:03 +0200)]
modelmenuitem: Fix icon/label alignment
gtk_box_pack_end will put the label child at the right side of the label
(in LTR orientation), but we want it left, directly next to the icon.
Also remove the spacing from the box child as this is a theme thing.
Timm Bäder [Wed, 11 Oct 2017 06:49:44 +0000 (08:49 +0200)]
grid: Only pass baselines to children that request it
Timm Bäder [Wed, 11 Oct 2017 06:25:20 +0000 (08:25 +0200)]
grid: Simplify allocating children
allocation->x and allocation->y are always 0. MAX'ing width/height with
1 is also wrong now since 0 is a valid width/height for widgets.
Timm Bäder [Wed, 11 Oct 2017 06:06:33 +0000 (08:06 +0200)]
eventcontrollerscroll: Emit ::scroll for -1/+1 discrete steps
The > 1 meant it only emits the signal for -2/+2 steps.
Timm Bäder [Wed, 11 Oct 2017 06:05:52 +0000 (08:05 +0200)]
tests: Add testgridbaseline
Which shows that GtkGrid currently computes baselines for all rows even
though not all of them might request a baseline.
Timm Bäder [Tue, 10 Oct 2017 19:54:53 +0000 (21:54 +0200)]
cssnode: Delay getting the parent style until we need it
There's an early return before.
Look at all those saved cycles.
Matthias Clasen [Tue, 10 Oct 2017 23:40:29 +0000 (19:40 -0400)]
Don't set child position in a ui file
It is not necessary, and causes assertions in some of
our tests.
Benjamin Otte [Tue, 10 Oct 2017 19:00:46 +0000 (21:00 +0200)]
cssnode: Don't put wrong styles in the style cache
~Company ╡ so TL;DR: we put the static style in the cache, but then
⤷ ╡ compute a child style from the animated style in the cache
⤷ ╡ and we put the child style also in the cache (because
⤷ ╡ it's not animated)
⤷ ╡ then we run the animation, but reuse the cache every time
⤷ ╡ for both child and parent
⤷ ╡ so after the animation is done, we end up with a cache that
⤷ ╡ has the correct static style for the parent but an
⤷ ╡ incorrect static style for the child
⤷ ╡ because that static style was computed from the
⤷ ╡ initial animated style
This fixes https://bugzilla.gnome.org/show_bug.cgi?id=763517
Timm Bäder [Tue, 10 Oct 2017 18:59:57 +0000 (20:59 +0200)]
cssnodedeclaration: Add gtk_css_node_declaration_to_string
Timm Bäder [Tue, 10 Oct 2017 10:53:06 +0000 (12:53 +0200)]
build: Drop redundant workaround
This is fixed and we require a meson > 0.39 anyway.
Timm Bäder [Tue, 10 Oct 2017 07:07:34 +0000 (09:07 +0200)]
rendernode: Don't leak mem_surface
Timm Bäder [Mon, 9 Oct 2017 15:38:54 +0000 (17:38 +0200)]
Don't try to snapshot invisible icons
These spew criticals when width == 0 || height == 0.
Timm Bäder [Sun, 8 Oct 2017 18:15:39 +0000 (20:15 +0200)]
scalebutton: Fix comparison for empty icon list
Timm Bäder [Sun, 8 Oct 2017 15:42:41 +0000 (17:42 +0200)]
stylecontext: Fix doc comment
There is no @cr here anymore.
Timm Bäder [Sun, 8 Oct 2017 15:38:38 +0000 (17:38 +0200)]
GdkDisplay: Add a private _emit_opened
So we don't have to use the slower g_signal_emit_by_name in startup
paths.
Timm Bäder [Sun, 8 Oct 2017 08:49:28 +0000 (10:49 +0200)]
textdisplay: Remove widgets parameter from gtk_text_layout_draw
All calls in gtk+ were passing NULL anyway.
Timm Bäder [Sun, 8 Oct 2017 08:40:48 +0000 (10:40 +0200)]
grid: Drop priv pointer
Matthias Clasen [Tue, 10 Oct 2017 04:18:21 +0000 (00:18 -0400)]
Reshuffle the css tests a bit
Matthias Clasen [Tue, 10 Oct 2017 04:16:10 +0000 (00:16 -0400)]
Reshuffle the a11y tests a bit
Matthias Clasen [Tue, 10 Oct 2017 04:14:48 +0000 (00:14 -0400)]
Add an install-tests option
Use this to enable or disable installed tests.
Matthias Clasen [Tue, 10 Oct 2017 03:35:19 +0000 (23:35 -0400)]
Install css api test again
Matthias Clasen [Tue, 10 Oct 2017 03:32:13 +0000 (23:32 -0400)]
Install css style tests again
Reinstate the installed tests for css style.
Matthias Clasen [Tue, 10 Oct 2017 03:29:10 +0000 (23:29 -0400)]
Install css parser tests again
Reinstate the installed tests for the css parser.
Matthias Clasen [Tue, 10 Oct 2017 03:24:23 +0000 (23:24 -0400)]
Install css node tests again
Reinstate the installed tests for css nodes.
Matthias Clasen [Tue, 10 Oct 2017 01:58:50 +0000 (21:58 -0400)]
Fix docs build
this include file can't be found, so just do without it.
Matthias Clasen [Mon, 9 Oct 2017 23:35:40 +0000 (19:35 -0400)]
Towards a working docs build
Add back images, content_files and expand_content files.
Anders Jonsson [Mon, 9 Oct 2017 23:19:22 +0000 (23:19 +0000)]
Update Swedish translation
Matthias Clasen [Mon, 9 Oct 2017 23:06:06 +0000 (19:06 -0400)]
Towards a working docs build
Pass mode: 'none' so escaping of <> in doc comments works.
Marek Cernocky [Mon, 9 Oct 2017 19:32:02 +0000 (21:32 +0200)]
Updated Czech translation
Matej Urbančič [Mon, 9 Oct 2017 18:54:24 +0000 (20:54 +0200)]
Updated Slovenian translation
Piotr Drąg [Mon, 9 Oct 2017 18:42:22 +0000 (20:42 +0200)]
Update Polish translation
Piotr Drąg [Sat, 7 Oct 2017 23:05:22 +0000 (01:05 +0200)]
gdk: Translate some more key names
These are used in the Keyboard panel of GNOME Settings.
https://bugzilla.gnome.org/show_bug.cgi?id=787866
Marek Kasik [Wed, 30 Aug 2017 15:56:00 +0000 (17:56 +0200)]
printing: Don't show duplicate printers
Check UUID for printers obtained via DNSSD whether
they are already installed on local CUPS server.
Don't show such printers.
Not all printers published via DNSSD have UUID entry though.
https://bugzilla.gnome.org/show_bug.cgi?id=786794
Matthias Clasen [Mon, 9 Oct 2017 03:19:35 +0000 (23:19 -0400)]
Add a transform node reftest
Matthias Clasen [Mon, 9 Oct 2017 02:45:05 +0000 (22:45 -0400)]
Add another cross-fade reftest
Matthias Clasen [Mon, 9 Oct 2017 02:19:22 +0000 (22:19 -0400)]
snapshot: Use a better placeholder
An empty container has the same effect as transparency
with the cairo renderer, but creates black with Vulkan.
To avoid this, explicitly use a transparent color node.
This fixes the css blendmode example in gtk4-demo with
the Vulkan renderer.
Matthias Clasen [Mon, 9 Oct 2017 01:13:43 +0000 (21:13 -0400)]
Regenerate blendmodes reftest
Matthias Clasen [Mon, 9 Oct 2017 01:12:22 +0000 (21:12 -0400)]
Fix blendmode shader
My reading of the spec formulas was imperfect.
Matthias Clasen [Mon, 9 Oct 2017 00:06:33 +0000 (20:06 -0400)]
Revise coordinate handling for blend nodes
This is the same change that was applied to cross-fade
nodes.
Matthias Clasen [Mon, 9 Oct 2017 00:05:16 +0000 (20:05 -0400)]
Stop using gsk_cairo_node_new_for_surface
Best to avoid handling the surface ourselves.
Matthias Clasen [Sun, 8 Oct 2017 23:21:09 +0000 (19:21 -0400)]
Add another blendmodes reftest
This tests all blendmodes. Again, the Vulkan renderer fails.
Matthias Clasen [Sun, 8 Oct 2017 22:36:57 +0000 (18:36 -0400)]
Revise the coordinate handling one more time
This makes the new reftests pass and hopefully does not
break other things.
Daniel Boles [Sun, 8 Oct 2017 21:19:13 +0000 (22:19 +0100)]
Dialog: Clarify that response ID 0 is not reserved
I only got so far in math, but it looks to me like zero isn’t positive.
We don’t reserve it, so be clear about that.
Daniel Boles [Sun, 8 Oct 2017 20:07:55 +0000 (21:07 +0100)]
MenuButton: Document the correct no-direction icon
Document open-menu-symbolic, which we use, not view-context-menu, which
does not exist.
Matthias Clasen [Sun, 8 Oct 2017 18:36:35 +0000 (14:36 -0400)]
Add a cross-fade node ref test
The Vulkan renderer doesn't pass this one either, currently.
Matthias Clasen [Sun, 8 Oct 2017 18:29:27 +0000 (14:29 -0400)]
Add a blendmode node reftest
The Vulkan renderer doesn't pass this, currently.
Matthias Clasen [Sun, 8 Oct 2017 18:03:19 +0000 (14:03 -0400)]
Fix application window snapshot differently
As Timm Baedert pointed out, the previous fix made the
menubar go on top of popovers, which is just wrong. Instead,
make gtk_window_snapshot handle all direct children of the
window, taking care to stack popovers correctly.
Matthias Clasen [Sun, 8 Oct 2017 17:49:59 +0000 (13:49 -0400)]
Expand the repeat node test
Still not exhaustive, but enough to find some issues.
Matthias Clasen [Sun, 8 Oct 2017 16:21:03 +0000 (12:21 -0400)]
Add a repeat node test
Matthias Clasen [Sun, 8 Oct 2017 15:51:00 +0000 (11:51 -0400)]
Add a basic cairo node test
Matthias Clasen [Sun, 8 Oct 2017 15:24:37 +0000 (11:24 -0400)]
Allow backend-specific reference images
This is not ideal, but lets us deal with differences for now.
Matthias Clasen [Sun, 8 Oct 2017 15:26:53 +0000 (11:26 -0400)]
vulkan: Fix cross-fade node coordinates
This is the same fix as was just committed for blendmode nodes.
Matthias Clasen [Sun, 8 Oct 2017 13:00:56 +0000 (09:00 -0400)]
vulkan: Fix blendmode coordinate handling
We were node handling coordinates correctly when dealing
with differently sized child nodes in a blendmode node.
This was showing up in the gtk4-demo css blendmode example,
for blendmodes other than normal.
Matthias Clasen [Sun, 8 Oct 2017 12:44:02 +0000 (08:44 -0400)]
vulkan: Fix repeat node coordinates
We were not treating non-trivial child bounds right at all.
This was visible in the css blendmode cmyk example in gtk4-demo,
for the normal blendmode.
Matthias Clasen [Sun, 8 Oct 2017 12:43:03 +0000 (08:43 -0400)]
inspector: Show child bounds for repeat nodes
The more information, the better.
Umang Jain [Fri, 6 Oct 2017 18:26:54 +0000 (23:56 +0530)]
Create tests for cairo node
https://bugzilla.gnome.org/show_bug.cgi?id=788534
Umang Jain [Fri, 6 Oct 2017 18:25:59 +0000 (23:55 +0530)]
gsk: Move gsk_cairo_node_new_for_surface into public API
https://bugzilla.gnome.org/show_bug.cgi?id=788534
Umang Jain [Wed, 4 Oct 2017 21:02:02 +0000 (02:32 +0530)]
gsk: Fix serialization of cairo node
https://bugzilla.gnome.org/show_bug.cgi?id=788534
Daniel Boles [Sun, 8 Oct 2017 12:15:33 +0000 (13:15 +0100)]
testmenubutton: Fix inverted keynav in the GtkMenu
GtkMenu’s own keynav code, which actually bothers to account for the
layout of items, only happens if columns > 1. So, adding items to 1
column using a reverse loop meant they were placed in the Menu’s list of
children in that order, and because we only have 1 column, Menu passes
keynav up to MenuShell, which doesn’t adjust for the items’ positions.
‘Fix’ that here by adding items in the same order they’ll have when laid
out in the Menu, so keynav does what you’d expect, not the opposite. For
that, it’s simpler just to use gtk_container_add().
Let’s presume users are using add(), attach() with a non-inverted loop,
or attach() with arguments that create 2+ columns and so GtkMenu keynav.
Timm Bäder [Sun, 8 Oct 2017 06:28:35 +0000 (08:28 +0200)]
snapshot: Set blend mode directly after pushing state
This is important since _push_state returns a pointer into a GArray
which could be invalidated and point to garbage after the subsequent
push_state call.
Matthias Clasen [Sun, 8 Oct 2017 03:31:47 +0000 (23:31 -0400)]
snapshot: Fix blend mode handling
We were getting out states confused and were always creating
a blend mode node with mode NORMAL.
Matthias Clasen [Sun, 8 Oct 2017 03:26:57 +0000 (23:26 -0400)]
gtk4-demo: fix a typo
The blend mode is called saturation, not saturate.
Matthias Clasen [Sun, 8 Oct 2017 02:45:49 +0000 (22:45 -0400)]
Adwaita: theme the shortcuts window search results
Add some margins, and, since we can, also move the spacing here.
Matthias Clasen [Sun, 8 Oct 2017 02:45:05 +0000 (22:45 -0400)]
Shortcuts window: Make search results themable
Add a style class to the box containing search results,
so we can apply style here.
Matthias Clasen [Sun, 8 Oct 2017 02:24:09 +0000 (22:24 -0400)]
application window: Make menubar appear
This needed to be ported to snapshot, still.
Matthias Clasen [Sun, 8 Oct 2017 00:13:13 +0000 (20:13 -0400)]
Adwaita: theme shortcuts windows a bit
Add some space around the content.
Matthias Clasen [Sun, 8 Oct 2017 00:12:18 +0000 (20:12 -0400)]
shortcuts: Add css names to some widgets
This will let us put some styling in place for these.
Matthias Clasen [Sat, 7 Oct 2017 23:54:47 +0000 (19:54 -0400)]
gtk4-demo: Fix the scrollbar popup menu example
A scrollbar is not a range anymore, so the callback
needs some adjustments (!).
Matthias Clasen [Sat, 7 Oct 2017 23:53:19 +0000 (19:53 -0400)]
scrollbar: keep populate-popup signal working
This is used for example in the source tab of gtk4-demo.
It broke because GtkScrollbar no longer is a GtkRange,
but rather has one. So we need to forward the signal.
Matthias Clasen [Sat, 7 Oct 2017 23:26:39 +0000 (19:26 -0400)]
notebook: Don't steal right-clicks from content
We only want to pop up the context menu in the tab strip.
Matthias Clasen [Sat, 7 Oct 2017 23:10:58 +0000 (19:10 -0400)]
Adwaita: Fix scrollbar theming a bit
Reinstate the fine-tune mode scrollbars.
Matthias Clasen [Sat, 7 Oct 2017 23:10:10 +0000 (19:10 -0400)]
scrollbar: Correct css docs
The .fine-tune class appears on the range node.
Matthias Clasen [Sat, 7 Oct 2017 22:27:51 +0000 (18:27 -0400)]
Drop the env var for scrolling control
This was never meant to be an official api, but rather
a transition help. Time to drop it for GTK+ 4.
Matthias Clasen [Sat, 7 Oct 2017 03:06:52 +0000 (23:06 -0400)]
textview: Fix memory handling
When cleaning up the text appearance struct, we forgot
to add the new strikethrough_rgba member to the copy
function.
Matthias Clasen [Sat, 7 Oct 2017 02:50:03 +0000 (22:50 -0400)]
printing: Fix page drawing
We were drawing frames around our drawing areas.
Matthias Clasen [Sat, 7 Oct 2017 02:33:24 +0000 (22:33 -0400)]
printing: Some fixes to the print dialog
Hide widgets that are meant to be hidden initially, and use
the right spin button apis.